fix build with libtorrent 2.1.0 #23475
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milahu
commented
Nov 9, 2025
| m_storageData[storage].files.rename_file(index, name); | ||
| #else | ||
| // libtorrent >= 2.1.0 | ||
| // FIXME rename_file is deprecated since libtorrent 77eb55f31e53f798d9b88c946d434b8076310d00 |
Contributor
Author
There was a problem hiding this comment.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| m_storageData[storage].files.rename_file(index, name); | ||
| #else | ||
| // libtorrent >= 2.1.0 | ||
| // FIXME rename_file is deprecated since libtorrent 77eb55f31e53f798d9b88c946d434b8076310d00 |
Check notice
Code scanning / CodeQL
FIXME comment Note
|
This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity. |
|
This PR was closed because it has been stalled for some time with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested with arvidn/libtorrent@a01469c
libtorrent fails to announce to https trackers with
... but this may be an issue with nixos linux
also i cannot login to the webinterface